Skip to content

Feature dtcenter/METplus#3247 link check - #473

Merged
jprestop merged 9 commits into
developfrom
feature_METplus3247_link_check
Jul 28, 2026
Merged

Feature dtcenter/METplus#3247 link check#473
jprestop merged 9 commits into
developfrom
feature_METplus3247_link_check

Conversation

@jprestop

Copy link
Copy Markdown
Collaborator

This PR is the same as this PR in the METplus repository, Feature #3247 link check #3325, minus the Contributor's Guide documentation. See the METplus PR for further details.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METcalcpy-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@jprestop jprestop added this to the METcalcpy-13.0.0 milestone Jul 14, 2026
@github-project-automation github-project-automation Bot moved this to 🩺 Needs Triage in METplus-13.0 Development Jul 14, 2026
@jprestop jprestop changed the title Feature me tplus3247 link check Feature METplus3247 link check Jul 14, 2026
@jprestop jprestop moved this from 🩺 Needs Triage to 🔎 In review in METplus-13.0 Development Jul 14, 2026
@JohnHalleyGotway JohnHalleyGotway changed the title Feature METplus3247 link check Feature dtcenter/METplus#3247 link check Jul 27, 2026

@JohnHalleyGotway JohnHalleyGotway left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of this PR. I see that the linkcheck action fails, as expected, with some broken links. But all other tests pass with no deprecation warnings. Thanks for you work on this.

@jprestop
jprestop merged commit 7868881 into develop Jul 28, 2026
9 of 10 checks passed
@github-project-automation github-project-automation Bot moved this from 🔎 In review to 🏁 Done in METplus-13.0 Development Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🏁 Done

Development

Successfully merging this pull request may close these issues.

2 participants